parse socketcand error messages to create a CAN error frame #1941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Could you add some test for this? |
Contributor
Author
Hi @zariiii9003 , |
occam25
force-pushed
the
process_socketcand_error_messages
branch
from
fa53e32 to
b30b834
Compare
zariiii9003
approved these changes
Jun 12, 2025
Collaborator
zariiii9003
left a comment
zariiii9003
left a comment
There was a problem hiding this comment.
Looks good, thank you 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recently socketcand project merged a PR to enable error CAN frames ( linux-can/socketcand#67 ) so now it can send error messages through the TCP socket when an error frame is generated by the CAN driver.
This PR updates the python-can socketcand interface to generate an error CAN message when socketcand error message is received